SemVer breakage re: NoDeprecatedCustomRule from graphql
See original GitHub issueThe graphql-language-service-interface
package, in going from version 2.4.2 to 2.4.3, relies on an export from graphql
named NoDeprecatedCustomRule
. The graphql
package added this export in v15.2.0. Furthermore, codemirror-graphql
revved its dependency version on graphql-language-service-interface
from 2.4.2 to 2.4.3 (requiring this change) when it went from 0.12.3 to 0.12.4. My dependency on graphiql
, which worked fine with my version of graphql
at 14.x
, on the publish of these new packages, started breaking, with a compiler error stating that 'NoDeprecatedCustomRule' is not exported from 'graphql'
. Now my package.json needs to pin both codemirror-graphql
to 0.12.3 and graphql-language-service-interface
to 2.4.2 so that I can remain compatible with graphql
at v14.
… * sigh *
Y’all… this is a mess, and it sucked up a bunch of my time because my builds started failing when I hadn’t changed any code. For already-published packages, there’s not really much you can do, but in the future, can you please be more aware of this kind of thing? In particular, the peerDependencies
for graphql-language-service-interface
are incorrect, as this package relies on graphql@^15.2.0
(since it needs NoDeprecatedCustomRule
introduced at that version) and appears to no longer be compatible with 14.x.
Thanks for your consideration. Let me know if I can provide any more information.
Issue Analytics
- State:
- Created 3 years ago
- Comments:9 (5 by maintainers)
Top GitHub Comments
peerDependencies
are… fun… Might I suggest a compile against the oldest acceptable version in thepeerDependencies
somewhere in the CI/CD chain? That would have definitely caught this.Works for me!