Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Breaking change with deprecated fields not being included by default

See original GitHub issue

In 15.4.0 release, this change was merged which prevents deprecated field from being returned when fetching the schema by default. Because these fields were returned before, this is a breaking change for projects that use this to update a local file for their schema.

In our case, the schema is used by a linter and our CI is now blocked because some fields are not in the schema anymore, yet we still use them in some places.

Proposed solutions:

Change includeDeprecated’s defaultValue to true
Or mark this change as breaking in the release notes

Happy to contribute to one of these options if the maintainers think it’s the way to go. Ping @IvanGoncharov since you worked on this recently.

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:12 (7 by maintainers)

Top GitHub Comments

2reactions

IvanGoncharovcommented, Nov 25, 2020

@Betree I added a flag to include deprecated args in #2855 Plan to release it this week.

1reaction

IvanGoncharovcommented, Nov 20, 2020

Maybe we can open a PR on prisma-labs/get-graphql-schema to include deprecated fields by default? I’m not sure how to achieve this with getInstrospectionQuery though, the prototype for IntrospectionOptions doesn’t mention anything related to deprecated fields.

Yes, I forget to update getInstrospectionQuery in my original PR and was to stubborn to actually check 🤦‍♂️ Working on a fix right now.

Top Results From Across the Web

Schema checks - Apollo GraphQL Docs

An existing field used by at least one operation had a default value added or changed. Non-breaking changes. These changes are detected by...

Deprecations by version - GitLab Docs

This is a breaking change. Review the details carefully before upgrading. The Phabricator task importer is being deprecated. Phabricator itself as a project...

Deprecated Fields, and Fields Marked as Obsolete

In the latest version of Business Central, a number of fields have been deprecated in the current release or marked to be obsolete...

Rules and categories | Buf®

Rules and categories. As discussed in the overview, buf categorizes breaking rules into four main categories: FILE : Generated source code breaking changes...

Versioning fields in GraphQL - LogRocket Blog

Whenever the change is non-breaking, as when adding a new type or field, we can apply it directly without fearing side effects.