GraphQL Review Team initiative.

As discussed on graphql-js-wg, we decided to run the “GraphQL Review Team” initiative.

Goal

Previously, we had a lot of PRs that stuck for months (sometimes for years) without any feedback. The goal of this initiative is to provide timely feedback on PRs, especially from new contributors.

Scope

This initiative is an experiment to see if this model will work or not. Moreover, it is intended to be a temporary measure until we get a team of active core maintainers.

Expectation

Members of @graphql/graphql-js-reviewers are expected to provide feedback on PR once tagged (by author, core member, etc.). They also are encouraged to review any PRs at any time, based on their individual time commitments.

Since team members are volunteers, please value their time and tag them only if:

1. PR didn’t get any feedback in 48 hours after it was posted.
2. All previous feedback was addressed, and PR is ready to merge.

Merge rule

PRs can be merged as-is following the current procedure. However, in case if PR (that does not require changes to the GraphQL spec) is stuck, anyone who has commit rights to this repo can merge it if all the below requirements are satisfied:

1. At least two members of the review team approved this PR, and no one rejected it.
2. Two weeks have passed since the last non-trivial change was added, and at least a week has passed since all review comments were resolved.
3. All review comments are addressed (we have a CI rule for that)
4. All non-trivial changes invalidate PR approval. Please re-request review in that case.

All PRs related to GraphQL spec proposal (typically have spec RFC label) should be reviewed extremely carefully by members of https://github.com/graphql/graphql-wg and thus excluded from the above rule.

Team

Updated on 26-01-2022

• @martijnwalraven
• @Cito
• @yaacovCR
• @IvanGoncharov
• @saihaj

[IvanGoncharov]

I’m in Ukraine🇺🇦 right now. The situation is stable and I managed to evacuate my relatives to the western part of Ukraine. Internet is more or less stable and I returning back to reviewing PRs and triaging issues.

However, there is a possibility I will be drafted or I would be unable to work for some other reasons. If something like that happens, please use review team to unblock PRs and for general maintenance. I have full trust in members of the review team to do this: @martijnwalraven @Cito @yaacovCR @saihaj

If you will be blocked by something (GH admin rights, graphql.org access, etc.) please reach TSC: https://github.com/graphql/graphql-wg/blob/main/GraphQL-TSC.md#tsc-members-1

[hwillson]

@IvanGoncharov just a heads up that @graphql/graphql-js-reviewers isn’t publicly viewable.