Inconsistent definition of value nodes

I noticed that “value nodes” are defined differently in language/ast and language/predicates:

export type ValueNode =
  | VariableNode  // <-- missing in isValueNode
  | IntValueNode
  | FloatValueNode
  | StringValueNode
  | BooleanValueNode
  | NullValueNode
  | EnumValueNode
  | ListValueNode
  | ObjectValueNode;

export function isValueNode(node: ASTNode): boolean %checks {
  return (
    node.kind === Kind.INT ||
    node.kind === Kind.FLOAT ||
    node.kind === Kind.STRING ||
    node.kind === Kind.BOOLEAN ||
    node.kind === Kind.NULL ||
    node.kind === Kind.ENUM ||
    node.kind === Kind.LIST ||
    node.kind === Kind.OBJECT ||
    node.kind === Kind.OBJECT_FIELD   // <-- missing in ValueNode
  );
}

Shouldn’t these two definitions be consistent with each other?

[IvanGoncharov]

It seems like you’re correct, unless @IvanGoncharov intentionally wanted isValueNode to mean is a constant value. We may want to switch the naming to better match the type though.

It’s a pure typo on my side. My idea was to match ValueNode exactly.

[Cito]

Thanks. I keep in touch with you when I have ideas or get feedback for improvement.