Additional fields on Relay connection plugin global config

Hi all,

There is a potential bug for additional extended fields (e.g.: totalCount) added globally on the on the Relay connection plugin when there’s a nested connection of the same type as the parent. I’ve created a small repo that reproduces the behavior: https://github.com/oliveiraethales/nexus-nested-totalcount-bug

It seems that configuring the totalCount in a one-off/per-field instead of in the global configuration of the plugin works properly; and the resulting schema is also different when doing so.

Any thoughts?

Thank you!

[bentron2000]

FWIW I got bitten with these changes moving from 1.0.0 to 1.1.0 with our extended connections with a totalCount field.

Documentation is not altogether clear and release notes don’t appear to clearly indicate this as a possibly breaking change between versions.

Documentation at Extending Connection / Edge types shows only the nodes version for a globally configured extension.

A use case where the connection is extended globally but provided by the resolve approach is not shown.

ie. it would require something like:

{
      ...
      resolve: ( root, args, ctx ) => {
        ...
        return { ...connectionFromArray( itemList, args ), totalCount: itemList.length}
      }
}

[tgriesser]

@edufelipe - just looked at the code, currently, if you use the resolve syntax then you need to specify the totalCount on the object returned:

resolve: (root, args, ctx, info) => {
  return {
    ...connectionFromArray(
      [
        { id: "1", name: "John" },
        { id: "2", name: "Amy" },
      ],
      args
    ),
    totalCount: 2,
  };
}

If you use the nodes return, then the totalCount fn gets called:

totalCount: (root, args, ctx, info) => {
  // This code is always executed, replacing the would-be correct root 'people' connection totalCount value (which would be 2)
  console.log("totalCount friends", root);
  return 3;
},
nodes: (root, args, ctx, info) => {
  // This code also gets executed properly
  // console.log("resolve friends");
  return [
    { id: 3, name: "Jack" },
    { id: 4, name: "Jane" },
    { id: 5, name: "Ana" },
  ];
},

At some point I’ll look into whether it makes sense to change this behavior, but just wanted to give you an idea of how it works for now.