__debug, __sql doesn't log sql queries made withing promises or resolves In Types

Hello world, I have a query that has promises with data loaders, In those dataloaders I do queries that don’t show up in the queries

__debug{ __sql{ sql}}

[japrogramer]

Yes I think that the sql tag should be resolved after the rest of the query is resolved … even after promises are resolved in the query. That would resolve a lot of issues.

[ktosiek]

Looking at the code of that middleware, I see it waits for all promises that where seen by the middleware before starting to resolve __sql. I think something like this might work:

class DjangoDebugContext(object):
    (...)
    def get_debug_promise(self):
        if not self.debug_promise:
            self.debug_promise = Promise.all(self.promises)
            self.promises = []
        return self.debug_promise.then(self.on_resolve_all_promises)

    def on_resolve_all_promises(self, values):
        if self.promises:
            self.debug_promise = None
            return self.get_debug_promise()
        self.disable_instrumentation()
        return self.object

    def add_promise(self, promise):
        if self.debug_promise:
            self.promises.append(promise)

Edit: it works, I’ve made a PR out of it: #591.