Avoid calling count unless it is required

It is checking the count for every query, but isn’t using it for anything AFAICT except hasNextPage

DjangoObjectType and DjangoConnectionField

[4.490] SELECT COUNT(*) AS "__count"
FROM "nsproperties_apt"

[0.159] SELECT "nsproperties_apt"."id", ...

This is a massive performance hit on postgresql. If I am selecting only 10 items and I don’t ask for the count then it should not call count. Even if the number of records is < 10 it still calls count.

For hasNextPage you can just iterate one past.

Related to #162 - it would be nice to get totalCount when we need it, but only pay the performance price then.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stickperson]

@crucialfelix how do you go about using SimplifiedDjangoConnectionField? I tried using it instead of DjangoFilterConnectionField, so I used DjangoFilterConnectionField instead of DjangoConnectionField. That didn’t work, so I dug into the code a bit and found this bit of code that uses DjangoFilterConnectionField.