Handling database transactions

I noticed that graphene-django doesn’t handle database transactions. I believe this is a issue that people should know or be careful about.

The same logic of DRF could be implemented as in the lines below that run in the dispatch method.

https://github.com/encode/django-rest-framework/blob/d985c7cbb999b2bc18a109249c583e91f4c27aec/rest_framework/views.py#L65-L102

Basically on one exception runs:

atomic_requests = settings.get('ATOMIC_REQUESTS', False)
if atomic_requests and connection.in_atomic_block:
   transaction.set_rollback(True)

In implementing this in graphene-django as we do not have the exception could run the rollback in the error checking of the execution result as in line 171.

https://github.com/graphql-python/graphene-django/blob/968002f1554e3a7a1c0617682be64b67823b2581/graphene_django/views.py#L167-L190

What do you think about this implementation?

[ace-han]

Hello, any progress on this issue or PR?

[overide]

@jkimbo I tried wrapping mutate method in Django’s transaction.atomic decorator and it worked. Why can’t we use it ? Just curious

@classmethod
@transaction.atomic
def mutate(cls, root, info, **kwargs):
    # do something