n+1 queries in execution dataloader docs

• What is the current behavior?

https://github.com/graphql-python/graphene/blame/master/docs/execution/dataloader.rst#L57-L58

>>> users = {user.id: user for user in User.objects.filter(id__in=keys)}
>>> print(users)
{1: <User: Tom>, 2: <User: Frank>, ...}

Database is hit once for each user.

---

• What is the expected behavior?

>>> user_ids = User.objects.filter(id__in=keys).values_list('id', flat=True)
>>> users = User.objects.in_bulk(user_ids)
>>> print(users)
{1: <User: Tom>, 2: <User: Frank>, ...}

A single query can be used to fetch all user IDs and users

---

• What is the motivation / use case for changing the behavior?

Performance

[nickvellios]

Closing out this issue. Using graphene 2.x and having inconsistent results. Will test further when we upgrade.

[jkimbo]

@nickvellios I’m not sure what you mean. Running User.objects.filter(id__in=keys) should only execute 1 db query. Are you seeing something different?