question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

on custom filters, chip always displays

See original GitHub issue

When there are custom filters the chip always displays. When the X on the chip is clicked the filter does reset, but the chip remains.

Thank you for the awesome component! ❤️

Expected Behavior

I expect the chip to disappear when its X is clicked with custom filters.

Current Behavior

The chip does not disappear when its X is clicked with custom filters.

Steps to Reproduce (for bugs)

Use column options such as below:

    const options = {
        filter: true,
        filterList: filterText,
        filterType: 'custom',
        customFilterListRender: v => 'Filter On',
        filterOptions: {
            names: filterText,
            logic: filterOut,
            display: Display,
        },
        sort: false,
    }

Your Environment

Tech Version
Material-UI @material-ui/core@3.9.2
MUI-datatables mui-datatables@2.7.0
React react@16.8.3
browser chrome 75.0.3770.142
platform mac

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:9

github_iconTop GitHub Comments

1reaction
akirwincommented, Sep 27, 2019

Curious if this is an issue for anyone else? Returning false is just returning an empty chip when doing this: customFilterListRender: v => { return (v !== undefined && v.length > 0 && v[0] !== '') ? 'Filter' : false },

1reaction
terraswatcommented, Aug 27, 2019

Thank you Gabriel, that worked perfectly! Please carry on with this awesome package.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Chips Widget – FilterEverything.Pro
In most cases, it does not need to be filled in and the widget will automatically display all the selected terms of all...
Read more >
Video: Advanced filter details - Microsoft Support
Training: You can use the Advanced Filter to create more powerful filters, ... Remove all the filters in a worksheet ... Sort data...
Read more >
React-admin - Filtering the List
To set default values for always on filters, use the filterDefaultValues prop of the <List> component instead. <List> uses the elements passed as...
Read more >
Chips - Material Design
Filter chips clearly delineate and display options in a compact area. ... Reply's input chips use custom color on two elements: text, container....
Read more >
ptcs-chip-data-filter - ThingWorx Web Component SDK
Property Type Triggers a changed event? data Object No query Object No showListFilter Boolean No
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found