question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Button focus persists after clicking it and retains an unfinished animated state

See original GitHub issue

Summary

Very strange button behavior. The animation is not completed until you click elsewhere. Which suggests buttons implicitly have “state”.

Expected Behavior

I expect for buttons to never surprise me, maybe an animation on click or a color change on hover. Once you start trying to reinvent the wheel with surprising animations and finite state machines, buttons become too surprising and frustrating to use.

⚠️ Clicking one button should not animate another button 🚨

Actual Behavior

Total confusion about something that is supposed to be dead simple.

URL, screen shot, or Codepen exhibiting the issue

weird

Steps to Reproduce

            <Button
              hoverIndicator={false}
              label={'A'}
              plain={true}
              focusIndicator={false}/>
            <Button
              color={'dark-1'}
              plain={false}
              primary
              focusIndicator={false}>
              B
            </Button>
  • Click Sign up.
  • Observe the awkward behavior that occurs: theres two aimations hovering and clicking.
  • Clicking one button, animates the other

Your Environment

  • Grommet version: 2.10.0
  • Browser Name and version: Chrome 79.0.3945.130
  • Operating System and version (desktop or mobile): macOS

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:10 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
felisiocommented, Mar 23, 2022

Hey @jcfilben thanks for the feedback, I’ll open a new issue for that, also I’ll take a look into the contributing guide to see how can I help with that issue. 😎

1reaction
jcfilbencommented, Mar 22, 2022

Hi @felisio I think a new issue could be created for this since the title and description for this current issue is really a separate issue that has already been solved. Would you be willing to file a new issue for this? Also if you are interested you can take it a step further and file a pull request for this. For more info checkout the contributing guide.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How can I make a button remain in its focus state after clicking ...
If user clicks anywhere, the button remains active. ... hold your desired focus state and the toggle the class on the child buttons...
Read more >
Safari Technology Preview Release Notes - Apple Developer
Fixed flickering while scrolling when the keyboard scrolling spring damping animation doesn't finish (255306@main, 255099@main) ...
Read more >
Focusing on Focus Styles | CSS-Tricks
It's important to make sure the state changes, from resting to focused to activated, are distinct. This means that each transition should be ......
Read more >
Animations and Transitions - Win32 apps - Microsoft Learn
Microsoft Windows uses a background flash animation to give feedback that the object was clicked. Transitions are animations used to keep users ...
Read more >
Keep button state - Adobe Support Community - 10120114
I want to know how I can set it up so that when each button is clicked, their 'state' holds to show that...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found