Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

global.colors.active not functional

See original GitHub issue

the activeStyle helper is using the hover color instead of the active color:

https://github.com/grommet/grommet/blob/ef9432a308f89304908e8f40d56e84c1053cf0af/src/js/utils/background.js#L127

as far as I can see, the active color is not used anywhere, even though its defined in base.js theme:

https://github.com/grommet/grommet/blob/4032b2e0e164fa0afc830eb59320089e53ccebf5/src/js/themes/base.js#L53

I would propose to effectively implement the active color

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:8 (4 by maintainers)

Top GitHub Comments

1reaction

oorestisimecommented, Mar 1, 2019

Yeah i meant to say that activeStyle is used there. (so the one who fixes this adds a test)

0reactions

ShimiSuncommented, May 3, 2021

@vavalos5 , that is correct, currently, both colors are defined the same way, and due to the backward compatibility of the theme, we do not have the flexibility to change those at the moment.

That being said, we have extended the active and hover theme props per component so components will have the flexibility to custom these colors as fit. The base theme is also supporting the following colors for extra customization alternatives, and it’s being used across the app:

 'active-background': 'background-contrast',
 'active-text': 'text-strong',

Also, with the new ‘kind’ button concept, the user is able to define the hover/active behavior and colors per type of button, which allows the customizability of applying different colors for different use cases.

I’ll be closing this issue since I think we have done what we can with the current backward compatibility constraints.