question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Grid - adding props from Box (`border` and `pad`)

See original GitHub issue

Expected Behavior

Grids would have similar props to Box

Actual Behavior

Box has many more stylistic props than Grid

Reasoning

As Grids and Boxes are both used for basic layouting often, it could be beneficial to add similar stylistic props to Grid.

Currently focusing on border and pad before considering other props

See this Slack thread for more info - https://grommet.slack.com/archives/C04LMHN59/p1578672831048600

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
srallencommented, Sep 18, 2020

@ShimiSun I’m hoping to participate in Hacktoberfest more broadly this year, so I’ll have a look! 😄

1reaction
skoshycommented, May 29, 2020

I was thinking the outer border only, to keep it consistent with how border would work if applied with css to a grid element and also with how border works in Box. Inner borders could be a separate prop if deemed necessary?

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to add padding and margin to all Material-UI components?
You can use de "Spacing" in a BOX component just by importing the component first: import Box from '@material-ui/core/Box';.
Read more >
Style Props - Chakra UI
Style props are a way to alter the style of a component by simply passing props to it. It helps to save time...
Read more >
Box - Grommet
A container that lays out its contents in one direction.
Read more >
Reference Table - Styled System
Reference Table. Styled System is organized into categories of style props. Each function provides the following props and maps to scales defined in...
Read more >
Layout and Grid System | Components - BootstrapVue
Bootstrap's grid system uses a series of containers, rows, and columns to layout and align content. It's built with flexbox and is fully...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found