question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Grommet [v2] - Warning: Unsafe lifecycle methods were found within a strict-mode tree

See original GitHub issue

Grommet v2 still uses unsafe lifecycle methods such as:

  • componentWill*
  • findDOMNode (since React 16.6)

Warning will appear under StrictMode.

Expected Behavior

Should not be using unsafe lifecycle methods.

Actual Behavior

Currently using lifecyle methods.

Steps to Reproduce

  1. Turn on React strictmode
  2. Look in console for warnings

Your Environment

  • Grommet version: 2
  • Browser Name and version: N/A
  • Operating System and version (desktop or mobile): N/A

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:12 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
alansouzaticommented, Nov 3, 2018

we will be soon removing this and switching to the hooks approach. We will delay this fix until we are on 16.7.

1reaction
nateq314commented, Apr 8, 2020

@ShimiSun Tried stable branch as you suggest and confirm that the findDOMNode warning is gone. Thanks!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to find out which package is using the UNSAFE ...
Hint: The warning issue comes from the incompatibility of react-helmet version 5 with react-js version 16.10 and later. Share.
Read more >
2.69598f97.chunk.js
nvar INFINITE_LOOP_ERROR = 'Popper: An infinite loop in the modifiers cycle has been detected! The cycle has been interrupted to prevent a browser...
Read more >
Grommet
part design system, part framework, and all awesome. grommet is a react-based framework that provides accessibility, modularity, responsiveness, and theming in ...
Read more >
Experts for merge lodash - Linknovate
Name Score News GitHub 124.1 12 John Doe B.V. 73.8 2 Dropbox LLC 62.1 3
Read more >
Central Repository: org/webjars/npm
org/webjars/npm ../ 1/ - - 1.3.26/ 2014-02-04 08:46 - 2-thenable/ - - 2.11.2/ 2015-06-18 14:17 - 2.14.14/ 2015-12-29 20:27 - 3.10.9/ 2016-11-24 19:28 ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found