question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Notification component to receive custom type and icon [feature request]

See original GitHub issue

Now Notification component is restricted by a few types: critical, warning, normal, unknown. It’s a great design for a purpose. At the same time, the component isn’t customizable as it might be.

Expected Behavior

It would be reasonable to add the custom type. For this case, the component could use a brand new customIcon prop to render any icon for a specific situation.

Actual Behavior

There is no custom type and a property for a custom icon

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:11 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
jcfilbencommented, Jun 13, 2022

Thanks for providing use cases! Sounds like we should add icon prop to Notification. If the icon prop is set it will override the notification.[status].icon set in the theme. If no icon prop is passed we will continue to use the icon defined in notification.[status].icon.

0reactions
jcfilbencommented, Oct 11, 2022

Closing since #6389 has been merged

Read more comments on GitHub >

github_iconTop Results From Across the Web

Adding custom icon to notification · Issue #3699 - GitHub
The icon provided to the component should be properly displayed. If no icon is provided, the default functionality and layout should not change....
Read more >
Create a Custom Notification Layout | Android Developers
DecoratedCustomViewStyle to your notification. This API allows you to provide a custom layout for the content area normally occupied by the ...
Read more >
Notifications - System experiences - Human Interface Guidelines
A notification can present a customizable detail view that contains up to four buttons people use to perform actions without opening your app....
Read more >
react-notifications-component - npm
Features. Touch support; Responsive notifications; Standard notification types; Custom notification types; Custom notification content ...
Read more >
How to create a custom toast component with React
The button will be used to close a particular toast notification. An image icon will display depending on the type of toast.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found