question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[TS] Add TypeScript unit testing pipeline

See original GitHub issue

Motivation

In the last few weeks, I’ve noticed a lot of issues outlining discrepancies between actual component bahaviour (outlined in .js files) and the types defined in index.d.ts files. I propose either migrating existing tests to .ts files, or adding TypeScript-specific tests alongside existing tests to help improve the Grommet TypeScript experience for users.

I’d like this issue to be a thread for initial discussion/proposals, and if/when we decide on a way forward I’ll log a separate issue to track migration/implementation progress.

Related Issues

Here is a list ot the types of TypeScript issues that are being raised recently:

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:10 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
alexmirringtoncommented, Sep 12, 2021

@jcfilben I’ve just created a new PR and closed the old one, as the dependencies for the old PR were quite a few months out of date. All technical details for reviewers can be found in the description of the new PR.

0reactions
jcfilbencommented, Sep 10, 2021

Hi @alexmirrington sorry for the long wait on this. Thanks for your patience and following up on the issue. I think typescript testing would be a beneficial addition to grommet. @ericsoderberghp do you know if there was a reason we were holding off on this or has it just been waiting for someone to take a stab at reviewing it?

Read more comments on GitHub >

github_iconTop Results From Across the Web

[TS] Add TypeScript unit testing support #5589 - GitHub
This is a proof-of-concept PR related to #5111 that adds strict TypeScript unit testing support, without forcing the rest of the grommet code...
Read more >
Unit testing TypeScript with Jest: Part Two — CI/CD pipeline ...
We have already gone through the setup for running unit tests on your machine using Jest. Running these tests locally is just one...
Read more >
UnitTesting and #IntegrationTesting with @typescript - YouTube
In this episode, we leverage the mocks we built last time to unit test the product list API in @expressjs and @ typescript....
Read more >
#UnitTesting and #Mocking in #TypeScript with #Jest - YouTube
Welcome to The SingleStore #Developer Live Stream. In this episode, we start building tests for our Express API in TypeScript.
Read more >
Add React and Tests to a TypeScript project
In this article you will learn how to add both an react app as well as tests to an existing TypeScript project for...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found