Correct way to log exception in interceptor?

Hey all. How should a catch-all exception logger look like? The code below does what I want, but I’m not sure if returning null is the best idea. I’ve checked the sample here, but there is no exception handling https://github.com/grpc/grpc-dotnet/blob/1f67ee2d00e60281dfc78a072b41fc575e0d1ce3/examples/Logger/Server/ServerLoggerInterceptor.cs.

I’m using .NET Framework and including gRPC and Microsoft.Extensions.Hosting packages so I don’t get the nice stuff that .NET Core has by default. Thanks!

    public override Task<TResponse> UnaryServerHandler<TRequest, TResponse>(TRequest request, ServerCallContext context, UnaryServerMethod<TRequest, TResponse> continuation)
    {
        try
        {
            return base.UnaryServerHandler(request, context, continuation);
        }
        catch (Exception exception)
        {
            _logger.LogError(exception.ToString());
            return null;
        }
    }

[wyepez]

core…and the implementation is pretty much the same as yours:

public override Task<TResponse> UnaryServerHandler<TRequest, TResponse>(TRequest request, ServerCallContext context, UnaryServerMethod<TRequest, TResponse> continuation)
    {
        try
        {
            return base.UnaryServerHandler(request, context, continuation);
        }
        catch (Exception exception)
        {
            _logger.LogError(exception.ToString());
            throw;
        }
    }

Adding async/await do the trick

[kle622]

@thdotnet yup. If you are using .net core, it is as simple as

services.AddGrpc(options = 
{
    options.Interceptors.Add<TInterceptor>();
});

If you are using .net framework, it is a bit more involved

_server = new Server
{
    Services = 
    {
        Proto.Service.BindService(ServiceInstance).Intercept(InterceptorInstance);
    }
    Ports = ...
}