question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Enable tag filtering within MapGrpcHealthChecksService()

See original GitHub issue

Is your feature request related to a problem? Please describe.

While Add[Async]Check() allows for specification of tags to then filter for them via MapHealthChecks()'s HealthCheckOptions.Predicate for HTTP GET requests, there’s no such support via MapGrpcHealthChecksService().

Describe the solution you’d like

I’d like to filter for tags via something like that mentioned Predicate property mechanism in MapGrpcHealthChecksService(), too.

Describe alternatives you’ve considered

  • Implementing an overloaded method - not really an option.
  • Using GrpcServiceEndpointConventionBuilder’s Add() method - failed to do so due to lack of documentation on how to use that convention builder correctly for my purpose.

Additional context

I’d like to use that filtering mechanism to separate between an AddDbContextCheck() readiness probe & another one for a liveness probe.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
JamesNKcommented, Jan 16, 2022

Btw I rewrote the PR and made some major changes. It now supports mapping health results to service names. It makes it easier to aggregate multiple health checks together.

1reaction
JamesNKcommented, Jan 15, 2022

I took a look at this. Does https://github.com/grpc/grpc-dotnet/pull/1565 let you achieve what you want?

Read more comments on GitHub >

github_iconTop Results From Across the Web

gRPC health checks in ASP.NET Core
Learn how to use gRPC health checks in ASP.NET Core.
Read more >
[POSSIBLE] How to filter history-only tags in the ...
I'm trying to utilize this exact filter, however I've found that if the tag has security enabled on it, the history attribute doesn't...
Read more >
Filtering tags with another tag on a dataset
Solved: So I'm trying to analyse the metadata of Danbooru2018 , to get practice with large datasets. The metadata includes a list of...
Read more >
List and filter your resources - Amazon Elastic Compute Cloud
Searching by a tag lets you filter the resources in the currently displayed table by a tag key or a tag value. Tag...
Read more >
Separate tags by category in a connectwidgets document
We use tag categories extensively in Connect. We are building a connectwidgets document. I was hoping to have filters by tag category.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found