question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow choosing the ManagedChannelProvider based on the NameResolver

See original GitHub issue

ManagedChannelBuilder.forTarget knows the scheme of the target, but doesn’t pass it to the ManagedChannelProvider. This makes it hard for the service loader to pick a proper Provider, because it may pick incorrectly.

Consider passing the scheme to the MCP, so that it can decide whether or not its available.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
dapengzhang0commented, Oct 4, 2019

@ST-DDT NameResolver should only be able to distinguish target types (e.g. in-process or not in-process), but should not distinguish transport types (e.g. netty or okhttp).

0reactions
ST-DDTcommented, Oct 4, 2019

Channel type selection (in-process/netty) via NameResolvers or a similar class would be a very nice feature for config based application setups. E.g. use in-process for tests and netty for production without changing a single line of code.

Read more comments on GitHub >

github_iconTop Results From Across the Web

ManagedChannelBuilder (grpc-all 1.51.0 API)
Sets the maximum message size allowed to be received on the channel. ... A NameResolver -compliant URI is an absolute hierarchical URI as...
Read more >
io.grpc.ManagedChannelBuilder Maven / Gradle / Ivy
A {@code NameResolver}-compliant URI is an absolute hierarchical URI as defined by ... That allows application's configuration to easily choose the name ...
Read more >
Index (grpc-all 1.21.0 API) - javadoc.io
Invoking this method moves the channel into the IDLE state and triggers tear-down of the channel's name resolver and load balancer, while still...
Read more >
Open Source Used In DNAC NDP Alvord - Cisco
form, that is based on (or derived from) the Work and for which the ... the Work or Derivative Works thereof, You may...
Read more >
深入浅出掌握grpc通信框架 - 51CTO博客
发现grpc-netty包实现ManagedChannelProvider接口: ... buildTransportFactory(), // TODO(carl-mastrangelo): Allow clients to pass this in new ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found