Grpc-Java : make sure to call shutdown()/shutdownNow() and wait until awaitTermination

Please answer these questions before submitting your issue.

What version of gRPC are you using?

grpc-core 1.13.1

What did you expect to see?

I saw lot ====> of .g.i.ManagedChannelOrphanWrapper : ~~~ Channel ManagedChannelImpl{logId=5, target=172.30.84.17:6565} was not shutdown properly!!! ~~~ Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.

java.lang.RuntimeException: ManagedChannel allocation site at io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.<init>(ManagedChannelOrphanWrapper.java:103) at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:53)

following each errors (StatusRuntimeException)

Client code :

ManagedChannel channel = ManagedChannelBuilder.forAddress(this.host, this.port).usePlaintext().intercept(interceptors).build();
    T t = runner.apply(stubSupplier.apply(channel).withDeadlineAfter(timeout, TimeUnit.MILLISECONDS));
    try {
      channel.shutdown().awaitTermination(5, TimeUnit.SECONDS);
      return t;
    } catch (InterruptedException e) {
      throw new IllegalStateException("Error happened during shutdown of validator gRPC channel", e);
    }

I start a new channel by request. Is-it correct ?

shutdown not done efficiently ?

[laymain]

Same here with the InProcessServerBuilder and gRPC 1.20.0

String name = UUID.randomUUID().toString();
Server server = InProcessServerBuilder.forName(name).addService(service).build();
server.start();
try {
    // do whatever....
} finally {
    server.shutdownNow().awaitTermination();
}

Channel ManagedChannelImpl{logId=44, target=directaddress:///8158b613-fec5-4656-a664-16c689b56f3b} was not shutdown properly!!! ~*~*~*
    Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.
java.lang.RuntimeException: ManagedChannel allocation site
	at io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.<init>(ManagedChannelOrphanWrapper.java:94)
	at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:52)
	at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:43)
	at io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:527)

[carl-mastrangelo]

The PR was https://github.com/grpc/grpc-java/pull/5283 which will end up in the 1.19 release (1.18 happens next week).

So the rpc in the try and only Channel.shutdown(); in a finally block + interrupt flag to true if interruptedException ?? Is it right?

Correct.