question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Server not accepting requests after update from 1.41.0 to 1.42.0

See original GitHub issue

After upgrading from 1.41.0 to 1.42.0, our services stopped receiving requests, and logging following INFO message:

  • [id: 0x84be72e8, L:/172.21.223.199:8080 - R:/172.21.225.64:58430] ignoring DATA frame for stream RST_STREAM sent.
  • sourceClassName: io.grpc.netty.shaded.io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener
  • sourceFileName: defaulthttp2connectiondecoder.java
  • sourceMethodName: shouldIgnoreHeadersOrDataFrame
  • sourceLineNumber: 648

We think that it could be caused by the following changes:

As we are running our workload also in a legacy environment where proxies don’t handle HTTP/2 100% correctly, the issue is probably in the Connection header.

Is your feature request related to a problem?

Connections with the Connection header are refused.

Describe the solution you’d like

Make this validation configurable, so have a new method in ServerBuilder class 🙏

Describe alternatives you’ve considered

Remove this validation completely.

Additional context

Unfortunately, this is a critical issue for us that blocks us from updating gRPC libraries 😢

My guess why netty doesn’t reject the connection with the Connection header is that there are still too many legacy workloads that could be broken by this change.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:10 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
ejona86commented, Nov 8, 2021

We can provide a system property or environment variable to disable the new validation. And then we just coordinate to determine a reasonable amount of time to leave it in place.

1reaction
ejona86commented, Nov 9, 2021

The system property io.grpc.netty.disableConnectionHeaderCheck will be available. Note that it will be io.grpc.netty.shaded.io.grpc.netty.disableConnectionHeaderCheck for grpc-netty-shaded.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Version 1.47.0 | Directadmin Docs
If you chose to update, uou must update BOTH your exim.pl, and install a new exim.conf. You can patch from 4.2.2 to 4.2.3....
Read more >
Release Notes v1.42.5 | Symphony | Documentation
Symphony will provide support for the new release version and 3 previous releases. If there is no new release for a given sprint...
Read more >
Download (UNIVERSAL) - ReadonlyREST
A solid, open source Elasticsearch security Plugin. Download the Free Version Now.
Read more >
Patch Notes - Adventure Quest 3D, Cross Platform MMORPG
1.41.0 - 1.42.0 fixes and updates ... After 15 seconds of no server communication, the Player will be ... Added a Setting to...
Read more >
Changelog — conan 1.43.4 documentation
Feature: Update conan new modern templates --template=cmake_lib and ... liburl3 version to be less than 1.26, so it does not break with requests...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found