question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Border: Class uses `string` for `title`, not `ustring`

See original GitHub issue
image

In addition, strings (both string and ustring) should be initizlied to .Empty and not null.

Fixing this may be a breaking change.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:7

github_iconTop GitHub Comments

3reactions
tigcommented, Jun 17, 2022

Why not adding it in the NStack? Do you want I do that?

I believe:

  1. Classes should always explicitly initialize members (so private type foo is BAD and private type foo = bar is good.
  2. strings (both string and ustring) should always be initialized to .Empty instead of null.

Changing Nstack to do this encourages bad developer behavior. So no, I don’t think you should do this to NStack.

1reaction
tznindcommented, Jul 31, 2022

we cant initialize with a default string.Empty, see the error:

You could do

public TopLevelContainer (Border border, string title = null)
{
    Initialize(Rect.Empty,border, title ?? string.Empty);
}
Read more comments on GitHub >

github_iconTop Results From Across the Web

Module:Interlinear
This is the module for Template:Interlinear and Template:gcl. The function invoked by the first one is p.interlinearise and the one invoked by the...
Read more >
وحدة:Adjacent stations
For each string which is not inside a function, translate it directly. -- • Strings with keys named "format" are Lua regular expressions....
Read more >
Module:Convert – Travel guide at Wikivoyage
mw.ustring.gsub fails with a table (to_en_table) as the replacement, ... (text not needing i18n). local append local pos = s:find(string.char(127), 1, ...
Read more >
List Error: is not a uistring - Coding and Debugging Help
I see this type of error A LOT when we are using Lists: setProperty() id parameter refers to an id (“txtError”) which does...
Read more >
Module:Mapframe
Must NOT use the special characters ^$()%. ... do local coord = mw.ustring.match(expandedTemplate, "<span class=\"geo%-dec\".->(.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found