question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Button: Should brackets always be drawn at full width?

See original GitHub issue

@BDisp nicely added support for Button having width > their text, along with TextAlignment support.

Visually, I think it looks weird that the brackets ([ and ]) are not drawn all the way at full width:

image

I was also considering changing the visual style of Button to use a better glyph than [' to make them look better. Eg. U+0254as in ┃Button Text┃`.

Thoughts?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:10

github_iconTop GitHub Comments

1reaction
tigcommented, Jun 9, 2020

I vote #647 nicely closes this.

1reaction
tigcommented, Jun 6, 2020

TurboVision drew drop-shadows on buttons (assuming there was space available). It was a great look. I’ve been thinking about that too.

image

We could support two styles:

  1. Legacy gui.cs: [ Button ]
  2. TurboVision:

image

I have a plan to support Bold and other ANSI formatting. Once that’s done I was planning on making the drawing of the < and > in default buttons only happen if the ConsoleDriver didn’t support bold (which will be possible).

Read more comments on GitHub >

github_iconTop Results From Across the Web

Make a button fill the full width of container element?
I'm converting from using div 's as buttons to actual buttons, and now I need to make buttons fill the full width of...
Read more >
When is it appropriate to expand a button to fill its parent ...
A full width button may be applicable for the following conditions -. You do not have a very wide (100% fluid) container.
Read more >
All my buttons are full width and I cant change it - Support
The button width in cornerstone does not effect the button size. I can change it to 5 px, or 1000 px, it still...
Read more >
How do you edit a button size in HTML?
Editing the size of a button in HTML is relatively easy. In the simplest form you just have to add a 'style' attribute...
Read more >
Positioning Content - Learn to Code HTML & CSS
Easily learn CSS and HTML layout and positioning with floats, inline-block elements, and uniquely positioned elements.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found