OutConsoleGridView no longer works - ENTER does not work

Recent changes to keyboard handling has broken ocgv.

https://github.com/PowerShell/GraphicalTools/blob/master/docs/Microsoft.PowerShell.ConsoleGuiTools/Out-ConsoleGridView.md

It implements StatusBar like this:

private void AddStatusBar()
        {
            var statusBar = new StatusBar(
                    _applicationData.OutputMode != OutputModeOption.None
                    ? new StatusItem[]
                    {
                        // Use Key.Unknown for SPACE with no delegate because ListView already
                        // handles SPACE
                        new StatusItem(Key.Unknown, "~SPACE~ Mark Item", null),
                        new StatusItem(Key.Enter, "~ENTER~ Accept", () =>
                        {
                            if (Application.Top.MostFocused == _listView)
                            {
                                // If nothing was explicitly marked, we return the item that was selected
                                // when ENTER is pressed in Single mode. If something was previously selected
                                // (using SPACE) then honor that as the single item to return
                                if (_applicationData.OutputMode == OutputModeOption.Single &&
                                    _itemSource.GridViewRowList.Find(i => i.IsMarked) == null)
                                {
                                    _listView.MarkUnmarkRow();
                                }
                                Accept();
                            }
                            else if (Application.Top.MostFocused == _filterField)
                            {
                                _listView.SetFocus();
                            }
                        }),
                        new StatusItem(Key.Esc, "~ESC~ Close", () => Close())
                    }
                    : new StatusItem[]
                    {
                        new StatusItem(Key.Esc, "~ESC~ Close",  () => Close())
                    }
            );

            Application.Top.Add(statusBar);
        }

With recent changes to Terminal.Gui something in how ProcessKey works broke this. The ENTER handler never gets called.

In my opinion, if an app uses StatusBar and defines a hotkey for the StatusBar, that should override all other controls; they should never get that key. This is how it used to work.

I did a test by modifying the ComputedLayout scenario:

var statusBar = new StatusBar (new StatusItem [] {
				new StatusItem(Key.CtrlMask | Key.Q, "~^Q~ Quit", () => Quit()),
				new StatusItem(Key.Enter, "~ENTER~ Message", () => MessageBox.Query ("Message", $"Hi")),
			});

By doing this, I would expect StatusBar to always win and ENTER would go to StatusBar first. But, that’s not what happens.

This is a breaking behavior change that I believe is a ship-stopper for V1.0.

@BDisp - please help me figure out what changed and a fix. Thanks.

[tig]

Fixed.

[tig]

My fix above is a fix (and should probably be incorporated regardless because it is more correct).

I’m curious to see what your proposed fix is!