Negative glob not working as expected

Hello,

I think I noticed issue with negative glob 🤔

Files structures looks like this:

foo/foo.html
bar/bar.html
gulpfile.js

Here goes the task

const {src, dest} = require('gulp');

module.exports.default = () => src(['**/*.html', '!bar/']).pipe(dest('dest'));

After running this task dest dir contains bar.

I expected dest dir not to include bar.

I made repl.it for this issue https://repl.it/@plesiecki/InvolvedIndianredProgramminglanguages. You can reproduce with single click (by clicking green run button at the top of the page). Remember to delete dest directory before you run the task (if it exists)

Gulp 4 Node 10.12.0 Npm 6.4.1

[phated]

@plesiecki I would have to do a ton of research to figure out if we could use it. Even then, it might cause unexpected issues which would require a major bump.

However, I did more investigating here and found that I was mistaken with the way ignores work. You need to specify node_modules/** and then node-glob removes the /** part and just matches the base directory. See the code at https://github.com/isaacs/node-glob/blob/master/common.js#L42 - so it wasn’t actually a regression and I just need to update our docs.

[plesiecki]

@phated Awesome. Just noticed fast-glob doesn’t have this issue. fast-glob is a drop-in replacement for node-glob. I can send a PR.