Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow overriding `highWaterMark`

See original GitHub issue

From what I’ve understood (correct me if I’m wrong) streams in object mode have a default highWaterMark of 16 which means only 16 vinyl files are processed at a time in parallel.

While 16 is probably a safe default to prevent exhausting the machine resources, it might be good to allow users to override that value for increased performance?

Issue Analytics

State:
Created 5 years ago
Comments:10 (5 by maintainers)

Top GitHub Comments

1reaction

phatedcommented, Mar 12, 2019

@ehmicky this is exceeding the scope of what I’d like to handle here. Maybe if I can start my office hours concept, then we can explore some of those questions more.

0reactions

ehmickycommented, Mar 12, 2019

No worries I understand. Sorry for going out of the initial scope of the issue.

Just to make the above point clearer, some shell commands only take single file paths as input and don’t handle globbing. I.e. those shell commands need to be repeated/iterated in order to be applied on several files.

One way to do it in a cross-platform way would be to use Promise.all() + execa(). I thought using a stream instead of Promise.all() would work just fine as I was not aware of any issues with mixing promises and streams.

No need to answer this message if you don’t have the time, I just wanted to make my former message clearer.