Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[etypes] Remove PCanonicalArray.nMissingBytes

See original GitHub issue

Found in EArray _buildSkip. Will require PTypes to be passed through _buildSkip, and for there to be a PType chosen on fields that are not found on the PType passed to _buildInplaceDecoder. I could see this either happening via an analog to _decodePType, (_encodePType), aka a canonical representation, or by explicitly passing through PTypes to Etypes.

There are also more assumptions made about PType representations in EArray, EBaseStruct than I would like (ex: mbytes := r.allocate(const(1), nMissing.toL), in EArray _buildSkip)

Issue Analytics

State:
Created 4 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

tpoterbacommented, Dec 17, 2019

you did this

0reactions

tpoterbacommented, Dec 10, 2019

Do you want to just code (len + 7) >>> 3 in EArray (say val nMissingBytes = (len+7) >>> 3 in the constructor). This would be a fast way to delete PCanonicalArray.nMissingBytes. The actual missing ness encoding scheme doesn’t seem tied to PArrays (notable the allocation is using a different alignment altogether).

This can in a more neutral place than PCanonicalArray object.