Don't create a window.Hammer global when in CommonJS

In hammer.js:

// this prevents errors when Hammer is loaded in the presence of an AMD
//  style loader but by script tag, not by the loader.
var freeGlobal = (typeof window !== 'undefined' ? window : (typeof self !== 'undefined' ? self : {})); // jshint ignore:line
freeGlobal.Hammer = Hammer;

Not sure what such a code wants to prevent, but the fact is that it’s polluting the global namespace (window) even when CommonJS or AMD is being used.

It shouldn’t.

[ibc]

we have 3rd party plugins the depend on there being a global

A bad practice should not be kept forever.

[aluanhaddad]

@arschmitz @runspired There needs to be a version that does not create a global. Even if I do not use any plugins, hammerjs still pollutes my namespace. Additionally more and more people continue to depend on the global because you continue to provide it.

It obviously is a chicken and egg problem but that is not a good reason to hold back the entire ecosystem.

moment did the right thing. moment deprecated their global. moment removed their global. moment broke many people’s apps. moment broke apps I was responsible for maintaining (forgot to import and paid the price). They did the right thing.

Please consider deprecating your global, giving plugin authors time to update and users time to decide, and then remove it completely.