Error using Joi.forbidden in conditional '.when'

Context

• hapi-swgger version: all versions
• any other relevant information: Joi schemas

What are you trying to achieve or the steps to reproduce ?

At the moment, hapi-swagger is not able to resolve Joi.forbidden with .when, see the following JOI schema example:

const Joi = require('joi');
const payloadValidation = Joi.object({
 a: Joi.string()
    .when('b', {
       is: Joi.exist(),
       then: Joi.forbidden()      // specifying Joi.forbidden() is resulting error here :(
    }), 
 b: Joi.string()
});

What result did you get?

Debug: internal, implementation, error
    TypeError: Uncaught error: Cannot set property 'x-alternatives' of undefined
    at module.exports.internals.properties.internals.properties.parseAlternatives (.../node_modules/hapi-swagger/lib/properties.js:529:40)
    at module.exports.internals.properties.internals.properties.parseProperty (.../node_modules/hapi-swagger/lib/properties.js:185:25)
    at joiObj.forEach (.../node_modules/hapi-swagger/lib/properties.js:391:45)
    at Array.forEach (<anonymous>)
    at module.exports.internals.properties.internals.properties.parseObject (.../node_modules/hapi-swagger/lib/properties.js:381:12)
    at module.exports.internals.properties.internals.properties.parseProperty (.../node_modules/hapi-swagger/lib/properties.js:144:29)
    at module.exports.internals.paths.internals.paths.getSwaggerStructures (.../node_modules/hapi-swagger/lib/paths.js:459:41)
    at routes.forEach (.../node_modules/hapi-swagger/lib/paths.js:217:38)
    at Array.forEach (<anonymous>)
    at module.exports.internals.paths.internals.paths.buildRoutes (.../node_modules/hapi-swagger/lib/paths.js:179:12)

What did you expect ?

It should not throw error, and able to resolve and see hapi swagger in (for example) localhost:3000/docs

[rhzs]

@robmcguinness it’s aligned with what other PR’s https://github.com/glennjones/hapi-swagger/issues/338 the PR would have been in here https://github.com/glennjones/hapi-swagger/pull/428/files#diff-327455fa29663c58312adf5955056773R496

However, it was commented out when got merged in https://github.com/glennjones/hapi-swagger/blame/2edaebb6793ac52527cea42e5e57c00693f60168/lib/properties.js#L517 now still left commented out https://github.com/glennjones/hapi-swagger/blob/master/lib/properties.js#L516

May you take a look please? Thanks

[Y-LyN-10]

There are plenty of PRs for this issue. Let’s fix it, please? @glennjones