PR In Progress - hapi@18

I am working on making a PR to update to hapi version 18 (released this past Friday).

One of the major changes in hapi 18 is the use of the WHATWG url parsing in Node. Specifically what used to be Url.parse('url') is now deprecated and has been replaced by new Url.URL('url'), which is more strict about url format validation. Because of that, the ip used in these tests, 194.418.15.24:80 is now being validated and is throwing an error on the 418.

Is there a reason why this specific IP is being used in the tests, or can I change it to 194.148.15.24:80 for the sake of WHATWG url format validation?

const Url = require('url');

// hapi 17:
Url.parse('194.418.15.24:7645'); // Url { protocol: '194.418.15.24:', ...

// hapi 18:
new Url.URL('194.418.15.24:7645'); // TypeError [ERR_INVALID_URL]: Invalid URL: 194.418.15.24:7645

[robmcguinness]

@WesTyler I think the tests that are breaking can be updated to support WHATWG url parsing. I don’t see anything about hapi-swagger that is specific to the breaking changes defined in the hapi@18 release notes. This lib should work with hapi@17 and hapi@18.

[WesTyler]

Excellent, thanks @robmcguinness !