Allow EXIFReader to use other encodings than ASCII/UTF-8

I try to read a bunch of old tiff files encoded on an old windows system. All ascii headers are encoded in “windows-1252”/“Cp1250” but EXIFReader doesn’t provide any ability to override the default encoding: UTF-8.

As far as I can see the issue is located in line 315 (Version 3.3.2):

return StringUtil.decode(ascii, 0, len, "UTF-8"); 

We could add two constructors to EXIFReader:

public EXIFReader() {
    this(Charset.forName("UTF-8"));
}
public EXIFReader(Charset charset) {
    this.charset = charset;
}

WDYT?

[haraldk]

No worries, I’ll continue to use UTF-8. 😀

– Harald K

[garretwilson]

Java property files was defined to be ISO-8859-1 from the start, so using it as a fallback there is an obvious choice …

Ah, @haraldk , you make a good point. You’re right, there is less probability in this situation that ISO-8859-1 would be the correct eight-bit encoding. Java properties files as you noted were originally defined to use ISO-8859-1.

I guess my bigger fear was that you might switch to only supporting ASCII, so I’m glad that’s not the case. 😄