CompoundDocument leaks a file descriptor

The CompoundDocument class uses a LittleEndianRandomAccessFile internally to read the file contents: https://github.com/haraldk/TwelveMonkeys/blob/24c6682236e5a02151359486aa4075ddc5ab1534/common/common-io/src/main/java/com/twelvemonkeys/io/ole2/CompoundDocument.java#L105

However, input.close() is never called, which means that the underlying RandomAccessFile can hold an open file descriptor indefinitely in a long-running process.

Is there any reason not to just add a CompoundDocument#close() method?

[tingley]

That seems to work. Tremendous, thanks for all your help!

[haraldk]

Thanks for following up on this!

That does indeed seem to be the case. Which is even worse…

My own code (the ThumbsDBImageReader) only uses the constructor taking an ImageInputStream parameter. And I believe this one is safe, as long as you close the ImageInputStream instance (which you can do externally).

Something like:

    private boolean isZipFileEncrypted(File file) throws IOException {
        // If you pass the File parameter to the CompoundDocument constructor it
        // opens a file pointer that is not released properly and remains open for
        // the entire lifetime of the application. Using an FileImageInputStream we take
        // control of the file pointer and release it properly after the check.
        try (ImageInputStream is = new FileImageInputStream(file)) {
            is.setByteOrder(ByteOrder.LITTLE_ENDIAN);
            new CompoundDocument(is);
            return true;
        } catch (CorruptDocumentException e) {
            return false;
        }
    }

This could perhaps work as a workaround for you, until I get the issue fixed.

Best regards,

– Harald K