BrowserFetcher downloads chromium by default to current directory (not to .dlls folder)
See original GitHub issueDescription
BrowserFetcher.cs by default downloads chromium binaries to current working directory BroswerFetcher.cs
...
DownloadsFolder = Path.Combine(Directory.GetCurrentDirectory(), ".local-chromium");
...
instead of to the directory where the binaries of project are located (as specified in BrowserFetcherOptions xml doc) BrowserFetcherOptions.cs
//...
/// <summary>
/// A path for the downloads folder. Defaults to [root]/.local-chromium, where [root] is where the project binaries are located.
/// </summary>
public string Path { get; set; }
//...
Expected behavior:
Either change the documentation, but better would be to download by default to the [root]/.local-chromium, where [root] is where the project binaries are located.
ie:
//...
DownloadsFolder =
Path.Combine(Path.GetDirectoryName(Assembly.GetEntryAssembly().Location),
".local-chromium");
//...
I can make PR for this - but the change is very small.
Versions
- Which version of PuppeteerSharp are you using? 1.10
- Which .NET runtime and version are you targeting? E.g. .NET framework 4.6.1 or .NET Core 2.0. happens on both
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (6 by maintainers)
Top Results From Across the Web
BrowserFetcher downloads chromium by default to current ...
Either change the documentation, but better would be to download by default to the [root]/.local-chromium, where [root] is where the project ...
Read more >Puppeteer Sharp: avoid downloading Chromium (bundle ...
However, I have to deploy my app in an environment that only has intranet access, which means Puppeteer's BrowserFetcher class is unable to ......
Read more >xinput1_3.dll in chrome folder is not build with ASLR
This is a dll that is a part of directX.You can find it in the home directory of chrome. On a new win...
Read more >Symbol files for Chromium DLLs not on symbol server
Hello Everyone,. I am using the path for the Google Symbol server as show below, but I can not resolve symbols for Canary,...
Read more >Dynamic-link library search order - Win32 apps
Safe DLL search mode (which is enabled by default) moves the user's current folder later in the search order. To disable safe DLL...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I stumbled upon this because I am have simple PuppeteerSharp wrapper, which periodically kills zombie chromium processes (sometimes some of the puppeteer awaited calls just freeze outside of the managed code) and I wanted to be able to locate which process (or assembly) started it, to just kill those chromiums… I can account for this in my code (by setting the Path property in BrowserFetcher explictily)- but found the documentation was misleading…
@Meir017 I like this idea of enum & user profile cache folder.
Yes. but it would also would mean that if my app is at
c:\myapp
and I call it fromc:\
or fromc:\myapp\
. Local-chromium would be always onc:\myapp\.local-chromium
. Now we are creating two.local.chromium
folders: one inc:\
and another inc:\myapp
.