NullReferenceException in Page.AddConsoleMessageAsync

The exception is thrown when I call Page.WaitForSelectorAsync, but it looks like the actual issue is that something is being logged to the console that PuppeteerSharp can’t handle correctly:

PuppeteerSharp.TargetClosedException: 'Protocol error(Runtime.callFunctionOn): Target closed. (Page failed to process Runtime.consoleAPICalled. Object reference not set to an instance of an object..    at PuppeteerSharp.Page.<>c.<AddConsoleMessageAsync>b__262_1(IJSHandle i) in C:\projects\puppeteer-sharp\lib\PuppeteerSharp\Page.cs:line 1672
   at System.Linq.Enumerable.SelectArrayIterator`2.MoveNext()
   at System.String.JoinCore[T](ReadOnlySpan`1 separator, IEnumerable`1 values)
   at System.String.Join[T](String separator, IEnumerable`1 values)
   at PuppeteerSharp.Page.AddConsoleMessageAsync(ConsoleType type, IJSHandle[] values, StackTrace stackTrace) in C:\projects\puppeteer-sharp\lib\PuppeteerSharp\Page.cs:line 1685
   at PuppeteerSharp.Page.Client_MessageReceived(Object sender, MessageEventArgs e) in C:\projects\puppeteer-sharp\lib\PuppeteerSharp\Page.cs:line 1471)'

This is reproducible on both PuppeteerSharp v8 and v9, running on .NET 7. Not sure I can share a repro case since the page I’m accessing requires authentication. When I look at the console for the page in question, I see some uncaught TypeErrors, e.g.:

[amaitland]

@kblok The JTokenType.Object check added in #2025, was there a reason to check the JToken type rather than RemoteObjectType.Object?

Calling console.debug(null); results in an exception with a callstack similar to this one.

[SkipBrowserFact(skipFirefox: true)]
public async Task ShouldNotFailForNullArgument()
{
	var consoleTcs = new TaskCompletionSource<string>();

	void EventHandler(object sender, ConsoleEventArgs e)
	{
		consoleTcs.TrySetResult(e.Message.Text);
		Page.Console -= EventHandler;
	}

	Page.Console += EventHandler;

	await Task.WhenAll(
		consoleTcs.Task,
		Page.EvaluateExpressionAsync("console.debug(null);")
	);

	Assert.Equal("JSHandle:null", await consoleTcs.Task);
}

Checking RemoteObject.Type == RemoteObjectType.Object resolves the exception. Argubily passing null to console.debug is pointless. Nonetheless it shouldn’t crash.,

[danports]

9.0.1 looks good, thanks!