liquidMethodMissing doesn't support object promises

Hi,

In attempt to implement a drop, i am trying to return an object from liquidMethodMissing method in order to lazily load objects.

For example:

class ProductsDrop extends Drop{
  constructor(api) {
      super()
  }
  async liquidMethodMissing(productHandle) {
      const product = this.api.getProductByHandle(productHandle)
      if (product) return product else return null
  }
}

and to call it as, for example: {{products[‘product handle’].name]}}

However, it seems that liquidMethodMissing supports only string type Promises.

  public liquidMethodMissing (key: string): Promise<string | undefined> | string | undefined {
    return undefined
  }

[almousa1990]

I was able to resolve the issue by adding a simple condition to the readProperty function, i am not sure if it breaks something else!

export function readProperty (obj: Scope, key: string) {
  if (isNil(obj)) return obj
  obj = toLiquid(obj)
  if (obj instanceof Drop) {
    if (isFunction(obj[key])) return obj[key]()
    if (obj.hasOwnProperty(key)) return obj[key]
    return obj.liquidMethodMissing(key)
  }
// HERE
  if (obj instanceof Promise) {
        return obj.then(resolvedObj=>readProperty(resolvedObj, key))
  }
  if (key === 'size') return readSize(obj)
  if (key === 'first') return readFirst(obj)
  if (key === 'last') return readLast(obj)
  return obj[key]
}

[harttle]

Then it’s a bug, we should fix it. Thank you for your work!