Unable to reassign include arguments locally within the include file itself

Related 11ty issue: https://github.com/11ty/eleventy/issues/2000

Steps to reproduce:

1. Create an include that accepts one argument.
2. Reassign the argument locally within the include.
3. Render the argument.
4. Invoke the include and specify a value for the argument.
5. Observe that the value does not get overridden.

Example:

parent.html

{% include child.html color: "red" %}

child.html

{% assign color = "green" %}{{ color }}

Expected behavior: the output is green.

Observed behavior: the output is red.

If it’s okay, I’d like to take a crack at fixing this (if you think it’s realistic for a first-time contributor). I have a failing test locally to confirm, but I’ll need to figure out where in the code it’s breaking.

[pdehaan]

@AleksandrHovhannisyan I’m pretty sure 11ty v1 (beta) supports the render tag as well (although it’s been a while since I’ve played with that).

Although I do see that https://github.com/11ty/eleventy/blob/19b4884e83e420a3b42f334aa922140f9cb18353/package.json#L107 is pinned to a very specific version of liquidjs, so we might need to tweak that line from the 11ty side (or else you can try manually installing the latest liquidjs locally and then try setting your own custom library instance.

---

UPDATE: Filed https://github.com/11ty/eleventy/issues/2059 from the 11ty side to bump liquidjs version back to latest.

[harttle]

After digging into Liquid and LiquidJS (I wrote this part long time ago and it takes me quite a while to figure it out, sorry for this), I find that:

include and layout are legacy tags which does not provide Context separation. In both Shopify/Liquid and LiquidJS, {% assgin %} in {%include%} files assigns to its parent template, thus will not hide include arguments. So it’s by design and that’s why {%include%} tag is deprecated.

render enforces Context separation by creating a new Context when render partials, but it has a bug resulting in {% assign %} inside {%render%} also not hiding render arguments. It’s definitely a bug and not consistent with Shopify/Liquid, I updated @AleksandrHovhannisyan 's PR and fixed this bug on v9.28.4, check it out!

layout is implemented just like include and still not works for now, I’ll consider provide a substitution for layout too if someone actually needs that. Feel free to open a feature request issue for it!