aws.vpc.DataAwsVpc cannot be used with VPC id without filtering

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave “+1” or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

node: 16.13.0
npm: 8.1.0

cdk: 0.9.4
cdk-tf: 0.9.4
@cdktf/provider-aws: 5.0.33

Affected Resource(s)

• aws.vpc.DataAwsVpc

Expected Behavior

To be able to use the examples provided on the aws_vpc data source documentation:

data "aws_vpc" "selected" {
  id = "vpc-1234567"
}

And be able to use that with @cdktf/provider-aws as follows:

import * as aws from '@cdktf/provider-aws';

new aws.vpc.DataAwsVpc(this, 'vpc', {
  id: 'vpc-1234567', 
});

Actual Behavior

The property id does not exist on the interface DataAwsVpcConfig.

Steps to Reproduce

import * as aws from '@cdktf/provider-aws';

new aws.vpc.DataAwsVpc(this, 'vpc', {
  id: 'vpc-1234567', 
});

Note

This looks like it can be done by using the AWS API filters instead, however documentation for HCL syntax clearly shows id being used which would be “more ideal”.

new aws.vpc.DataAwsVpc(this, 'vpc', {
  filter: [
    {
      name: 'vpc-id',
      values: [
        'vpc-1234567', 
      ],
    }
  ],
});

[ansgarm]

For the record (as your link seems to be the wrong one 😅) AWS.accessanalyzer.Accessanalyzer

[jsteinich]

I took an initial look at fixing this (I’ve looked into something similar in the past) and it’s potentially a bit tricky. It seems that provider schemas tend to mark id as optional for most (maybe all) resources when really it doesn’t make sense to set it (not sure if Terraform even allows it). We had put some rules in place to try and work around this but they really aren’t working at this time (maybe never did fully). If Terraform is ok with setting id perhaps the best action is to just listen to the schema and remove custom rules, but if not, we’ll need to some research / experimenting to come up with better rules.