question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[FEAT] Make `secrets` parameter optional so we can use this action just to get the token.

See original GitHub issue

Is your feature request related to a problem? Please describe. The secrets parameter should not be mandatory. There is the option for exportToken, which is what I want to use to configure the Vault Terraform provider. However, with secrets being mandatory, it requires me to read a secret that I do not need.

Describe the solution you’d like The secrets parameter to not be mandatory, and allow us to use this action to simply get a Vault token to pass into other tooling.

Describe alternatives you’ve considered Honestly, none. Just grabbing a secret for the sake of using this action? I suppose I could create my own action that simply gets the token itself and posts to the login endpoint, but why not just use this one when it does the job?

Additional context I am evaluating this action to use JWT with Github OIDC, as a potential replacement for internal automation around Vault access from CI. When configuring the Terraform Vault provider, you minimally need an endpoint, a token and, in our case, a namespace. I just want that sweet, sweet token. I don’t wish to pass secrets into Terraform directly for example. It seems unnecessary to read a secret just to use this action to get a token.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:9
  • Comments:9

github_iconTop GitHub Comments

4reactions
DmitryMihailovcommented, Feb 15, 2022

This action is almost perfect, but making the secrets fields mandatory wasn’t needed…

4reactions
elstakcommented, Feb 15, 2022

+1 Good to decouple authentication (get and populate VAULT_TOKEN) from fetching secrets, potentially multiple times, by reusing the same auth token.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Aws cdk don't provide a way to create secrets with specified ...
Just feed in the secrets via CloudFormation parameters with NoEcho option. Use a dummy value if you can't feed in optional values during...
Read more >
Referencing AWS Secrets Manager secrets from Parameter ...
Retrieve Secrets Manager secrets when using other AWS services that already support references to Parameter Store parameters.
Read more >
HTTPie 3.2.1 (latest) docs
The METHOD argument is optional, and when you don't specify it, HTTPie defaults to: GET for requests without body; POST for requests with...
Read more >
Cisco SD-WAN Security Configuration Guide, Cisco IOS XE ...
You can encrypt DNS packets only when the DNScrypt feature is enabled on the ... To automatically retrieve registration parameters, Cisco vManage uses...
Read more >
Complete Guide to Macros & Rolls - Roll20 Wiki
When using @{selected}, you need to first select the token you want to use, before making the roll, and you can only have...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found