question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

infra: add check for images in docs

See original GitHub issue

Motivation

As explained in this guide, we should compress images that are added as part of a docs pull request. This sometimes gets forgotten and then a PR gets merged with too large images.

Instructions

We should make this part of the PR process. I’ve added a label called docs-compress-images.

We should write a GitHub action that checks the following:

  • Is it a docs PR?
  • Has one or more images been added?

If the answer to both is yes, the build should only succeed if the label docs-compress-images is added. Otherwise it should fail.

Reference

We have a similar (yet not exactly the same) use case for the changelog label. You can check it out for inspiration.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:9 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
marionschleifercommented, Oct 2, 2020

@Hard-Coder05 @wicked-smart thank you both for your PR. Please be nice to each other, it’s all good. We don’t assign issues as explained in our Hacktoberfest blogpost.

@Hard-Coder05 I made a comment on your PR.

@wicked-smart it’s great that you’ve started contributing to open source. Let’s leave your PR open for now, until the other one is merged. We explain in the blogpost how to look for issues. If you need help, it’s also explained in the blogpost where to get it 🙂

1reaction
wicked-smartcommented, Oct 2, 2020

@Hard-Coder05 ok boss , my bad …relax !!! , as i said i’m quite new to this. I guess one needs to get assigned to make PR . I saw your check didn’t passed , so then fixed it and pushed.

Alright, buddy, please enlighten me on what should i do now…is there a thing called deleting PR or something ?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Google Docs: Inserting Images - GCF Global
To search for an image: ; Click Insert > Image > Search the web. clicking the Search the web button ; A search...
Read more >
How to Edit Images Inside Google Docs & Slides
The first step is to insert the image into your Google Doc or Slide. If you're looking for an image to get started...
Read more >
Add and edit images - Google Workspace Learning Center
Add and edit an image "" · Click Insert and then Image and choose where to get your image from (Drive, Photos, the...
Read more >
How to Add Caption To Images In Google Docs - Inkit
1. Open your documents with google docs. · 2. Click on 'Insert image.' · 3. Choose the image you want to add from:...
Read more >
How to Insert Diagrams in Google Docs | Lucidchart Blog
Open the correct Google Doc. · Go to Add-ons > Lucidchart Diagrams > Insert Diagram. · Find the diagram you need to insert...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found