Remove trace context from events

We just updated to v1.3.3. Everything went smoothly, except some of our event handlers started failing because the new trace_context values don’t stringify correctly in NodeJS

We set the HASURA_GRAPHQL_STRINGIFY_NUMERIC_TYPES for a similar reason in order to deal with BigInt values correctly

Is there any way the trace context in event payloads could respect this setting? What are some of our other options?

Right now we’ve added something like this to our event handlers, but its a bit of a hack:

  if (event?.trace_context) {
    Object.keys(event.trace_context).forEach((key) => {
      if (typeof event.trace_context[key].toString === 'function') {
         event.trace_context[key] = event.trace_context[key].toString()
      }
    })
  }

[nason]

Dumb question probably: Why do you want trace_context to be stringified in the first place?

Not a dumb question at all @tirumaraiselvan! We have an ingest endpoint set up that that puts events onto an AWS EventBridge bus, which other services (mostly lambdas) subscribe to.

This has been working really well for us, and I opened this issue after upgrading to v1.3.3 because the event payload we were receiving stopped being JSON.stringify-able, and our ingest started failing.

We don’t explicitly need the trace context, but its addition broke our ingest endpoint until we added the patch in the 1st comment. That said, it would be very cool one day to be able to use this trace context to correlate hasura action -> event -> ingest -> subscriber(s)

[andoks]

FYI: the field “trace_context” is not documented in https://hasura.io/docs/latest/event-triggers/payload/. Should it be?