win10 local_name is 'Unknown'

• bleak version: 0.6.1
• Python version: 3.6
• Operating System: Win10
• BlueZ version (bluetoothctl -v) in case of Linux:

Description

I use scanner get_discovered_devices but I see device name’s ‘Unknown’ always

What I Did

I saw scanner.py in the 135. line:
if ( not new_device.name and event_args.BluetoothAddress in self._scan_responses ): new_device.name = self._scan_responses[ event_args.BluetoothAddress ].Advertisement.LocalName found.append(new_device) this new_device.name never nothing because in the 160. line: return BLEDevice( bdaddr, local_name, event_args, uuids=uuids, manufacturer_data=data BLEDevice init local_name = 'Unknown

[dlech]

FYI, I wrote some thoughts about how to make Windows more like other platforms by internally combining the different advertisement types in #394.

[pjbosco]

This requires an update to the constructor of BLEDevice. If the ‘name’ parameter is None, the BLEDevice.name gets set to ‘Unknown’.

So long as BLEDevice never accepts None as a name, the code in the following branch in the dotnet scanner.py will never execute:

            if (
                not new_device.name
                and event_args.BluetoothAddress in self._scan_responses
            ):
                new_device.name = self._scan_responses[
                    event_args.BluetoothAddress
                ].Advertisement.LocalName

Allowing BLEDevice to accept None as a name, and then replacing the code in the dotnet scanner.py with the following fixes the issue for me:

            if not new_device.name:
                if event_args.BluetoothAddress in self._scan_responses:
                    new_device.name = self._scan_responses[
                        event_args.BluetoothAddress
                    ].Advertisement.LocalName or "Unknown"
                else:
                    new_device.name = "Unknown"

@dlech is right… This of course is contingent upon a ScanResponse type advertisement being available for all device addresses that were found since that is what contains the local name. I have situations where sometimes a device will show Unknown and sometimes it will show its actual name. I think this has more to do with the advertising interval and scans not waiting for a corresponding ScanResponse for each address that has been encountered.

Hope this helps!