Setting withHistory disables historyInputFile and historyOutputFile

It took me a while to figure this out and I had to go through your code to find it. In MojoToReportOptionsConverter the following code uses the default temp location when withHistory is set to true. In that case the historyInputFile and historyOutputFile are ignored. To me it would be more logical that when withHistory is set a check is done to see if the locations are set and use those instead of the tmp location. If you want I can make a pull request but I’d have to get set up first.

private void determineHistory(final ReportOptions data) {
    if (this.mojo.useHistory()) {
      useHistoryFileInTempDir(data);
    } else {
      data.setHistoryInputLocation(this.mojo.getHistoryInputFile());
      data.setHistoryOutputLocation(this.mojo.getHistoryOutputFile());
    }
}

[bentlor]

I agree with peter-janssen. It is essential that these are checked in the correct order, and both have effects as described in the FAQ. I was struggling to set up the suite because I thought that they have to be used together in order to use a different path and use history. Also, the log doesn’t display “Using history file …” when only using the location parameters, which suggests that there is no history file being used. TL;DR: At least document in the FAQ how these 3 properties actually work.

[ilgun]

Agreeing with @peter-janssen as well, it confused me too 😃