Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fallback Method in @Fallback not being called when combined with @Retry

See original GitHub issue

Environment Details

Helidon Version: 2.2.0
Helidon MP
JDK version: JDK 11.0.7
OS: Windows 10
Docker version (if applicable):

Problem Description

The fallback method defined in @Fallback is not getting called after reaching max retries when the target method is also annotated with @Retry. When the target method is only annotated with @Fallback, the fallback method gets called when the execution of the target method failed.

Expected behavior: The fallback method get called after the max number of retries has been reached.

Steps to reproduce

With Resource as: `
private final BusinessService businessService;

@Inject
public GreetResource(BusinessService businessService) {
        this.businessService = businessService;
}

@POST
@Path("/process")
@Consumes(MediaType.APPLICATION_JSON)
@Produces(MediaType.APPLICATION_JSON)
public Response processReversal(JsonObject jsonObject) {
    String requestId = jsonObject.getString("requestId");
    String result = businessService.callUnreliableApi(requestId);
    return Response.status(Response.Status.NO_CONTENT).build();
}`

And Business service as: `@ApplicationScoped public class BusinessService {

@Fallback(fallbackMethod = "testFallback", applyOn = RuntimeException.class)
@Retry(maxRetries = 3, retryOn = RuntimeException.class )
public String callUnreliableApi(String requestId)  {
	
	HttpURLConnection conn = null;
	int responseCode = -1;
	
	try {
		URL obj = new URL("http://localhost:8080/api");
		conn = (HttpURLConnection) obj.openConnection();
		conn.setRequestMethod("GET");
		responseCode = conn.getResponseCode();
		String responseMsg = conn.getResponseMessage();
	}
	catch (IOException e) {
		throw new RuntimeException("IOException ocurred");
	}finally {
    	if (conn != null) {
    		conn.disconnect();
    	}
    }
	
	if (responseCode != 200 ) {
		throw new RuntimeException("Unsuccessful call");
	}
	
    return "API called successfully!";
}

public String testFallback(String requestId) {
	return "API call failed!";
}