Path param can NOT be resolved in register method of Service

Environment Details

• Helidon Version: 0.10.0
• Helidon SE
• JDK version: java version “1.8.0_181”
• OS: Windows 10
• Docker version (if applicable):

---

Problem Description

Currently the Service provides a update method to define routine rules, but it can not provides concept like Jaxrs Resource and sub resource, the path params can NOT be resolved in register method.

Steps to reproduce

Imagine the following case.

I want to build comments api under a certain post, I could design APIs like this.

/posts/post-id/comments

I would like register it in the PostService like this:

@Override
    public void update(Routing.Rules rules) {
        rules.get("/", this::getAllPosts)
            .post("/", this::savePost)
            .get("/{id}", this::getPostById)
            .put("/{id}", this::updatePost)
            .delete("/{id}", this::deletePostById);
            .register("/{id}/comments", new CommentService());
    }

And in the CommentService:

    @Override
    public void update(Routing.Rules rules) {
        rules.get("/", this::getAllComments)
            .post("/", Handler.of(JsonObject.class, this::saveComment, this::errorHandler));
    } 

All uri path in CommentService should be appended /{id}/comments, and all path params should be resolved in CommentService, eg post id in the path.

post id in /{id}/comments is null, check my sample, https://github.com/hantsy/helidon-sample/blob/master/quickstart-se/src/main/java/io/helidon/examples/quickstart/se/CommentService.java#L37.

[barchetta]

@romain-grecourt and I dug into this and it looks like a bug. Proposed fix (needs a bit more verification):

diff --git a/webserver/webserver/src/main/java/io/helidon/webserver/Request.java b/webserver/webserver/src/main/java/io/helidon/webserver/Request.java
index 3437928..a30cd1d 100644
--- a/webserver/webserver/src/main/java/io/helidon/webserver/Request.java
+++ b/webserver/webserver/src/main/java/io/helidon/webserver/Request.java
@@ -441,13 +441,13 @@ abstract class Request implements ServerRequest {
                 HashMap<String, String> map = new HashMap<>(this.params.size() + params.size());
                 map.putAll(this.params);
                 map.putAll(params);
-                return new Path(path, params, new Path(this.path, map, null));
+                return new Path(path, map, new Path(this.path, map, null));
             } else {
                 HashMap<String, String> map = new HashMap<>(this.params.size() + params.size() + absolutePath.params.size());
                 map.putAll(absolutePath.params);
                 map.putAll(this.params);
                 map.putAll(params);
-                return new Path(path, params, new Path(absolutePath.path, map, null));
+                return new Path(path, map, new Path(absolutePath.path, map, null));
             }
         }
     }

[spericas]

@barchetta @romain-grecourt Could we add a test for that as part of the PR?