Discuss: (PHP) built-ins are currently purposely not highlighted.

Describe the issue

When PHP is put into the pre and code tags, everything renders correctly except certain functions. They are missing <span class="hljs-keyword">and just left as regular text while other functions get the <span>.

Which language seems to have the issue?

Seems to be PHP but maybe other languages also that need the class=“hljs-keyword”.

Are you using highlight or highlightAuto?

I’ve tried both and both are giving me the same exact problem.

Sample Code to Reproduce

https://jsfiddle.net/b2dj79qh/

Expected behavior

You should see “json_decode” & “file_get_contents” functions white as the other function “isset” is syntaxed.

Additional context

I’m pretty sure they are all considered the same (isset, file_get_contents, json_decode, etc…), so I feel like they should all be the same color no?

[joshgoebel]

Closing this original issue as #wontfix, expected behavior in agreement with @Ayesh:

I don’t think highlighting built-in functions at the cost of storing this many functions is worth it.

We only highlight reserved words - not ALL built-ins (which is a huge list), though there is already separate discussion to highlight all function dispatch as part of the #2500 initiative.

[joshgoebel]

Remove built-in interfaces and other class names. Except for Throwable and perhaps ArrayAccess, the other ones are quite niche ones, and there are more to come. It will only add maintenance burden with very little gain. This reduces the php.js file by ~1.5KB pre-gzip.

@Ayesh I’d say if you want to do this along with the other work you’re doing on PHP lately this would be a small improvement. We may want to move the few remaining to a _ attribute inside keywords (since we don’t have a nice way to say “keywords, but do not highlight”) vs built_in so that NO interfaces are highlighted (rather than just randomly highlighting the few we include) for now.