"Local" distributor not working
See original GitHub issueThis is related to the following part of the documentaion: “Custom Part Data”:
The price breaks on some parts can’t be obtained automatically because:
- they’re not offered by one of the distributors whose web pages KiCost can scrape/query, or
- they’re custom parts.
For these parts, you can manually enter price information as follows:
#. Create a new field for the part named kicost:pricing
in either the schematic or library.
#. For the field value, enter a semicolon-separated list of quantities and prices which
are separated by colons like so::
1:$1.50; 10:$1.00; 25:$0.90; 100:$0.75
(You can put spaces and currency symbols in the field value. KiCost will
strip everything except digits, decimal points, semicolons, and colons.
Others currency are acepted by use of the standardize ISO 4217 alpha3 format,
e.g. USD1.50
, EUR1.00
)
You can also enter a link to documentation for the part using a field named kicost:link
.
The value of this field will be a web address like::
www.reallyweirdparts.com/products/weird_product.html
After KiCost is run, the price information and clickable link to documentation for the part are shown in a section of the spreadsheet labeled Local. If you want to associate the pricing and/or documentation link to a particular source or distributor, just place an extra label within the field key to indicate the source like so:
kicost:My_Weird_Parts:pricing
kicost:My_Weird_Parts:link
Then the pricing and documentation link for that part will appear in a section of the spreadsheet labeled My_Weird_Parts
.
Current code in master
fails to do it. I think the original implementation was by @devbisme and then @mdeweerd tried to fix something related to variants and all started to fail.
I changed the code in this patch: 343297c0a3aa9a58b7ac914ef9a80ad9d5eb1519
I’m looking for comments about it. After applying this patch I found various interesting differences in the tests. You can see a big difference in fitting_test.xlsx
.
The current result can be observed here: https://github.com/xesscorp/KiCost/suites/2616517652/artifacts/57324546
And the current master
is here: https://github.com/xesscorp/KiCost/suites/2579090530/artifacts/56243325
You’ll see that in master
JP1 is separated from JP2 and JP3. This is because the code fails to interpret kicost:pricing
. You can also note that we don’t get the Local
distributor as stated in the documentation.
Is the new version correct? I guess that the local
namespace is there to avoid collision with other tools. As an example: if another tool makes a different use of the DNP
field you can use kicost:DNP
to avoid problems. Is this correct?
Issue Analytics
- State:
- Created 2 years ago
- Comments:29 (15 by maintainers)
Top GitHub Comments
Yes this is very good visually. Good for multiparts where the fields becomes really long.
I liked this new
|
separator, I think it is more clear.