USB discovery entries for Z-Wave JS are too generic
See original GitHub issueThe problem
in /homeassistant/generated/usb.py
there are some entries for VID/PID combo’s that identify USB dongles with a specific integration.
For Z-Wave JS this is included in the file:
{
"domain": "zwave_js",
"vid": "10C4",
"pid": "EA60"
}
The VID:10C4 and PID:EA60 belong to a very generic cp210x chipset by Silicon labs. The problem is that all other devices that aren’t Z-Wave JS radio’s now show up as Z-Wave.
I’m sure this isn’t a problem for the current core integrations as Z-Wave JS and ZHA are about the only onces that use USB, but if you’d use any other dongles from a custom integration this will become very confusing for users. Also for future proofing purposes, it might be useful to identify more devices with this chipset within core.
One solution could be to identify based on description (iProduct) too just like ZHA but i’m not sure if those are provided with the Z-Wave sticks.
What is version of Home Assistant Core has the issue?
core-2021.9.0
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
USB Discovery
Link to integration documentation on our website
https://www.home-assistant.io/integrations/usb/
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
^ not a z-wave dongle but is identified as one.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:2
- Comments:39 (23 by maintainers)
Top GitHub Comments
I think the problem is well understood, we are just waiting for vendors to provide identifiers at this point.
Even those current vendors might want to bring out different sticks in the future (e.g. Matter, etc.) with the same SiLabs chip on-board. It’s just weird to assume that a CP210x UART bridge is a Zwave device.