Sparkle Feed Explosion for non-Sparkle feed
See original GitHub issueDescribe the bug Attempting to create recipes with https://www.macpostgresclient.com/download.php, which is not a Sparkle feed to my knowledge, causes Recipe Robot to explode.
To Reproduce Steps to reproduce the behavior:
- Open Recipe Robot
- Enter https://www.macpostgresclient.com/download.php URL
- Watch explode!
Expected behavior Recipes created.
Screenshots
Output:
Processing: https://www.macpostgresclient.com/download.php
Input path looks like a Sparkle feed.
Sparkle feed is: https://www.macpostgresclient.com/download.php
[ERROR] Recipe Robot exploded with unexpected error: 'utf-8' codec can't decode byte 0xaf in position 59: invalid start byte
Traceback (most recent call last):
File "/Applications/Recipe Robot.app/Contents/Resources/scripts/recipe-robot", line 92, in main
process_input_path(facts)
File "/Applications/Recipe Robot.app/Contents/Resources/scripts/recipe_robot_lib/inspect.py", line 161, in process_input_path
facts = inspect_func(input_path, args, facts)
File "/Applications/Recipe Robot.app/Contents/Resources/scripts/recipe_robot_lib/inspect.py", line 1891, in inspect_sparkle_feed_url
raw_xml = curler.download(checked_url, headers=headers, text=True)
File "/Applications/Recipe Robot.app/Contents/Resources/scripts/recipe_robot_lib/curler.py", line 174, in download
output = download_with_curl(curl_cmd, text=text)
File "/Applications/Recipe Robot.app/Contents/Resources/scripts/recipe_robot_lib/curler.py", line 160, in download_with_curl
curl_cmd, text=text, capture_output=capture_output
File "/Applications/Recipe Robot.app/Contents/Resources/scripts/recipe_robot_lib/curler.py", line 150, in execute_curl
text=text,
File "/Library/AutoPkg/Python3/Python.framework/Versions/Current/lib/python3.7/subprocess.py", line 490, in run
stdout, stderr = process.communicate(input, timeout=timeout)
File "/Library/AutoPkg/Python3/Python.framework/Versions/Current/lib/python3.7/subprocess.py", line 964, in communicate
stdout, stderr = self._communicate(input, endtime, timeout)
File "/Library/AutoPkg/Python3/Python.framework/Versions/Current/lib/python3.7/subprocess.py", line 1755, in _communicate
self.stdout.errors)
File "/Library/AutoPkg/Python3/Python.framework/Versions/Current/lib/python3.7/subprocess.py", line 841, in _translate_newlines
data = data.decode(encoding, errors)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xaf in position 59: invalid start byte
_[]_
[xx]
q-||-p
||
_/ \_
[0m
Desktop (please complete the following information):
- macOS: 10.15.7
- Recipe Robot Version: 2.0.0
autopkg version
: 2.2/usr/local/autopkg/python --version
: 3.7.5
Additional context Add any other context about the problem here.
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (1 by maintainers)
Top Results From Across the Web
sparkle-cli - Sparkle: open source software update framework ...
Sparkle 2 includes a command line utility that can update Sparkle-based applications and bundles. ... [--feed-url feed-url] [--user-agent-name display-name] ...
Read more >Sparkle Explosion Stock Video Footage for Free Download
Browse 1056 amazing Sparkle Explosion stock footage videos for royalty-free download from the creative contributors at Vecteezy!
Read more >Show Cattle Explosion | Sunglo Feeds
Contains Optaflexx™ for increased weight gain, feed efficiency, and increased carcass leanness on market cattle during the final 28-42 days.
Read more >No popup when running the latest version? #1326 - GitHub
I'm trying to use Sparkle with Qt (binding for Go) app. sparkle.m: #import static ... An error occurred while parsing the update feed....
Read more >Track Star - Etsy
Ronco "Sound Explosion" & "Star Trackin '76" 2 x Compilation Vinyl ... TRACK & FIELD Cotton/Lycra Headband - Non Sparkle Lettering.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Sorry for the false alarm, confirmed this is now working as expected.
Good catch. I’ve cautiously added some code in 326ad0f that detects common download content-types and redirects Recipe Robot’s effort from “inspect Sparkle feed” to “inspect download URL.” That seems to solve the problem for your example input. I’ll do some testing to make sure the change doesn’t break parsing for any actual Sparkle feeds, and tentatively add this change to v2.2.0.