Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

When compare locations, only path is compared, params are ignored

See original GitHub issue

As you can see in TurboNavRule

    private fun locationPathsAreEqual(first: String?, second: String?): Boolean {
        if (first == null || second == null) {
            return false
        }

        return URI(first).path == URI(second).path
    }

This will cause unexpected pop presentation. Shouldn’t params be compared too? Since params also reflect page state.

Issue Analytics

State:
Created 3 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

2reactions

jwarkcommented, Jul 21, 2021

@fffx @jwark I’ve changed the default behavior in #178, but have added a new path property configuration option to restore the previous behavior for any desired paths.

Thanks @jayohms for putting in the effort to get this fixed and for letting us know, I really appreciate it. 😃

1reaction

jayohmscommented, Jul 21, 2021

@fffx @jwark I’ve changed the default behavior in #178, but have added a new path property configuration option to restore the previous behavior for any desired paths.