Add httpClient abstractions SendRequestStatusToGetASmokeAlarm

At the moment we are missing proper abstractions SendRequestStatusToGetASmokeAlarm class.

[mjmilan]

Forgive me if this is already taken care of architecturally, but that sounds like a very campaign specific method name to me.

Should we be placing such campaign specific code in the application, and if so, should we be treating it as a campaign specific add-in?

I would check, but I am using a mobile phone at the moment…

[mgmccarthy]

@chinwobble, the problem with using the IHttpClient abstraction on this one (and why I haven’t moved to it yet) is b/c of the http headers involved in putting the auth token onto the POST request. At least that was my reasoning when I wrote it.

I just did a quick search around and it looks like TwitterService uses the IHttpClient static instance in a POST scenario. Instead of attaching the http headers to the client, it builds an HttpRequestMessage and attaches the headers to the request, then sends the request via HttpClient. In other words, HttpClient stays “header agnostic”, which it should as it’s a static instance, it will be used for both GET and POST scenarios and we would not want to attach headers to the client for an instance where it’s being used in the wrong call.

If you’d like to have a go at changing SendRequestStatusToGetASmokeAlarm to utlizie the static IHttpClient like TwitterService does, please do and let me know how it goes.